Skip to content

additions and reroute - #37

Open
Kistine wants to merge 1 commit into
gh-pagesfrom
add-pies
Open

additions and reroute#37
Kistine wants to merge 1 commit into
gh-pagesfrom
add-pies

Conversation

@Kistine

@Kistine Kistine commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

added pie charts that allow filtering the dataset and viz by Year and
Qtr.

also pointed to 'employee_salaries' dataset - not sure why it was
pointing to 'latest_employee_salaries" but that seemed to drop older
info. Is it ok to change this @timwis?

added pie charts that allow filtering the dataset and viz by Year and
Qtr.

also pointed to 'employee_salaries' dataset - not sure why it was
pointing to 'latest_employee_salaries" but that seemed to drop older
info.
@Kistine Kistine self-assigned this Aug 28, 2018
@Kistine
Kistine requested a review from timwis August 28, 2018 14:24
@timwis

timwis commented Sep 27, 2018

Copy link
Copy Markdown
Contributor

latest_employee_salaries is a view that shows the latest quarter. By allowing you to filter on year/quarter that isn't necessary. The only issue, I imagine, is that when you first load it it will show all quarters combined, which misleading totals. Is that the case? Perhaps you can show me on your computer. A more ideal solution would be a "default filter" rather than a base filter, where the latest quarter/year is selected but could be changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants